Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests fail for length-0 record batch #16395

Closed
asfimport opened this issue Apr 7, 2017 · 5 comments
Closed

Integration tests fail for length-0 record batch #16395

asfimport opened this issue Apr 7, 2017 · 5 comments
Assignees
Milestone

Comments

@asfimport
Copy link

asfimport commented Apr 7, 2017

Patch incoming

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

Related issues:

Note: This issue was originally created as ARROW-783. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Leif Mortenson / @leifwalsh:
Hi all. How can I run the tests that fail and does anyone have any pointers to what is likely to be the problem? @julienledem @jacques-n @xhochy @wesm

@asfimport
Copy link
Author

Wes McKinney / @wesm:
I would start with my PR

#505

if you build both libraries (mvn package for java) then run

python integration_test.py --debug

it would print a bunch of command lines, for the one that fails with Java, you can step into the place where it's failing and see what's up. We added zero-length batch roundtrips in C++ a while back and it exposed a bunch of bugs https://github.com/apache/arrow/blob/master/cpp/src/arrow/ipc/ipc-read-write-test.cc#L245

@asfimport
Copy link
Author

Wes McKinney / @wesm:
I would love to look at this, but I'm not unable to build the project in IntelliJ due to some kind of dependency conflict:

SLF4J: The requested version 1.5.6 by your slf4j binding is not compatible with [1.6, 1.7]
SLF4J: See http://www.slf4j.org/codes.html#version_mismatch for further details.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Arrow Java Root POM ........................ FAILURE [0.586s]
[INFO] Arrow Format ...................................... SKIPPED
[INFO] Arrow Memory ...................................... SKIPPED
[INFO] Arrow Vectors ..................................... SKIPPED
[INFO] Arrow Tools ....................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.742s
[INFO] Finished at: Sat Apr 08 17:11:40 EDT 2017
[INFO] Final Memory: 20M/633M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on project arrow-java-root: Execution validate of goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check: java.lang.AbstractMethodError: org.slf4j.impl.JDK14LoggerAdapter.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;[Ljava/lang/Object;Ljava/lang/Throwable;)V
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>org.apache.maven.plugins:maven-checkstyle-plugin:2.17

@asfimport
Copy link
Author

Wes McKinney / @wesm:
I think I fixed up things here: #505. The length-0 case is slightly undefined for variable length types. It seems we should relax to allow the offsets vector to have no elements also (since they'll never be inspected)

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 505
#505

@asfimport asfimport added this to the 0.3.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants