Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable variable length vector fillEmpties() fills an extra value #16481

Closed
asfimport opened this issue Apr 21, 2017 · 1 comment
Closed

Nullable variable length vector fillEmpties() fills an extra value #16481

asfimport opened this issue Apr 21, 2017 · 1 comment

Comments

@asfimport
Copy link
Collaborator

The fillEmpties() method is needed to update the offset vector in between non-null values. But it fills the current value which we are trying to set as well, when this is unnecessary. In fact, in the case of setValueCount(), this can result in an unnecessary reAlloc() call.

Reporter: Steven Phillips / @StevenMPhillips
Assignee: Steven Phillips / @StevenMPhillips

Note: This issue was originally created as ARROW-875. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Wes McKinney / @wesm:
Issue resolved by pull request 579
#579

@asfimport asfimport added this to the 0.3.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant