Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Dictionary "delta" building logic in builder_dict.h produces invalid arrays #16925

Closed
asfimport opened this issue Oct 14, 2019 · 2 comments
Closed

[C++] Dictionary "delta" building logic in builder_dict.h produces invalid arrays #16925

asfimport opened this issue Oct 14, 2019 · 2 comments
Assignees
@wesm
Labels
Component: C++ Priority: Blocker Marks a blocker for the release Type: bug
Milestone
0.15.1

Comments

@asfimport
Copy link

Looking at the unit tests for the dictionary delta logic – the arrays that are produced by subsequent invocations of Finish yield DictionaryArray instances with partial dictionaries. I think this is misleading (I was surprised to find this while working on ARROW-6861). We should develop a different approach to computing dictionary delta.

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

PRs and other links:

Note: This issue was originally created as ARROW-6869. Please see the migration documentation for further details.
@asfimport
Copy link
Author

Wes McKinney / @wesm:
cc @alendit

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 5687
#5687

@asfimport asfimport added this to the 0.15.1 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesm wesm

Labels
Component: C++ Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
0.15.1
Development

No branches or pull requests
2 participants
@wesm @asfimport