Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] ListType constructor argument is redundant #16980

Closed
asfimport opened this issue Dec 2, 2019 · 1 comment
Closed

[C#] ListType constructor argument is redundant #16980

asfimport opened this issue Dec 2, 2019 · 1 comment

Comments

@asfimport
Copy link

https://github.com/apache/arrow/blob/master/csharp/src/Apache.Arrow/Types/ListType.cs#L28

 

The ListType constructor has two arguments but 'ValueDataType' can be determined by 'Filed.DataType' and 'ValueFiled' can be created by valueDataType.

It seems to me that the constructor should be separated to "ListType(Field valueField)" and " ListType(IArrowType valueDataType)".

 

Reporter: Takashi Hashida / @HashidaTKS
Assignee: Takashi Hashida / @HashidaTKS

PRs and other links:

Note: This issue was originally created as ARROW-7289. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Kouhei Sutou / @kou:
Issue resolved by pull request 5931
#5931

@asfimport asfimport added this to the 0.16.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant