You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This generates some compile time errors since the second argument of the ListBuilder constructor expects a unique pointer.
However, I guess the example shows the correct case, where we want to still be able to use the DoubleBuilder after constructing the ListBuilder, so I probably shouldn't std::move it to the constructor as a unique_ptr.
I'm not sure how to fix this as I don't know which functionality is desired.
Wes McKinney / @wesm:
Sorry about that, this example has bit-rotted due to some API changes (i.e. shared to unique ptr) in the last 6 months. It should not be happening again very soon, but we'll need to conform this to the current API
In the row_wise_conversion code example we find:
This generates some compile time errors since the second argument of the ListBuilder constructor expects a unique pointer.
However, I guess the example shows the correct case, where we want to still be able to use the DoubleBuilder after constructing the ListBuilder, so I probably shouldn't std::move it to the constructor as a unique_ptr.
I'm not sure how to fix this as I don't know which functionality is desired.
Reporter: Johan Peltenburg / @johanpel
Assignee: Wes McKinney / @wesm
PRs and other links:
Note: This issue was originally created as ARROW-1543. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: