Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] row_wise_conversion example doesn't correspond to ListBuilder constructor arguments #17558

Closed
asfimport opened this issue Sep 15, 2017 · 2 comments
Assignees
Milestone

Comments

@asfimport
Copy link

In the row_wise_conversion code example we find:

    std::shared_ptr<DoubleBuilder> components_values_builder =
        std::make_shared<DoubleBuilder>(arrow::default_memory_pool());
    arrow::ListBuilder components_builder(arrow::default_memory_pool(),
        components_values_builder);

This generates some compile time errors since the second argument of the ListBuilder constructor expects a unique pointer.

However, I guess the example shows the correct case, where we want to still be able to use the DoubleBuilder after constructing the ListBuilder, so I probably shouldn't std::move it to the constructor as a unique_ptr.

I'm not sure how to fix this as I don't know which functionality is desired.

Reporter: Johan Peltenburg / @johanpel
Assignee: Wes McKinney / @wesm

PRs and other links:

Note: This issue was originally created as ARROW-1543. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Sorry about that, this example has bit-rotted due to some API changes (i.e. shared to unique ptr) in the last 6 months. It should not be happening again very soon, but we'll need to conform this to the current API

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 1157
#1157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants