Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add static ctor ArrayData::Make for nicer syntax in places #17776

Closed
asfimport opened this issue Nov 7, 2017 · 1 comment
Closed

[C++] Add static ctor ArrayData::Make for nicer syntax in places #17776

asfimport opened this issue Nov 7, 2017 · 1 comment

Comments

@asfimport
Copy link

Because of the fickleness of std::make_shared, we are having to store a vector of buffers in an lvalue rather than passing the buffers in the make_shared function call as an initializer list. This makes things a bit awkward, and could be made possibly better with a factory function

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

PRs and other links:

Note: This issue was originally created as ARROW-1777. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 1353
#1353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants