Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Implement "any" reduction kernel for boolean data #17840

Closed
asfimport opened this issue Nov 22, 2017 · 5 comments
Closed

[C++] Implement "any" reduction kernel for boolean data #17840

asfimport opened this issue Nov 22, 2017 · 5 comments

Comments

@asfimport
Copy link

asfimport commented Nov 22, 2017

Reporter: Wes McKinney / @wesm
Assignee: Andrew Wieteska / @arw2019

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-1846. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
I think the chunked array short-circuiting should be a dataframe-level optimization

@asfimport
Copy link
Author

Wes McKinney / @wesm:
With fresh eyes and ARROW-8792 in the rear view mirror, I believe Any should be implemented as a ScalarAggregateFunction, with some way for agg functions to communicate that they have short-circuited to the KernelContext

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Isn't this the same thing as Max for booleans?

@asfimport
Copy link
Author

Wes McKinney / @wesm:
It is, but it just needs to be able to short-circuit (i.e. if the max/any value in the state is already true, then skip examining the data chunk) for when we have parallel evaluation

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 8294
#8294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant