Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer][Integration] Serialize schema- and field-level custom metadata in integration test JSON format #18214

Closed
asfimport opened this issue Mar 4, 2018 · 4 comments

Comments

@asfimport
Copy link

asfimport commented Mar 4, 2018

I don't believe we are doing this at present. We should validate that each implementation properly handles the incoming metadata from other Arrow emitters

Reporter: Wes McKinney / @wesm
Assignee: Ben Kietzman / @bkietz

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-2255. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
[~emkornfield@gmail.com] handling of Schema and Field custom_metadata is pretty inconsistent. To assert this is properly handled we would need to add it to the integration test JSON format

@asfimport
Copy link
Author

Micah Kornfield / @emkornfield:
agreed.  I'll try to make this happen for 1.0.0.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Looks like this is nearly done. I will review when I can

@asfimport
Copy link
Author

Ben Kietzman / @bkietz:
Issue resolved by pull request 6556
#6556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants