Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] pa.union() mode argument unintuitive #18290

Closed
asfimport opened this issue Mar 22, 2018 · 1 comment
Closed

[Python] pa.union() mode argument unintuitive #18290

asfimport opened this issue Mar 22, 2018 · 1 comment

Comments

@asfimport
Copy link

>>> pa.union([pa.field('x', pa.int16())], 'sparse')
UnionType(union[dense]<x: int16=0>)
>>> pa.union([pa.field('x', pa.int16())], 'dense')
UnionType(union[dense]<x: int16=0>)
>>> pa.union([pa.field('x', pa.int16())], 42)
UnionType(union[dense]<x: int16=0>)

I would suggest allowing "sparse" and "dense" strings as aliases to the internal enum values, and disallowing everything else.

Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou / @pitrou

PRs and other links:

Note: This issue was originally created as ARROW-2341. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 1778
#1778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants