You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, PrimitiveArray::new passed with null_count != 0 creates an array that does not follow the specification, as it is initialized with a None null bitmap but a non-zero null_count.
This method also makes no attempt to check for the buffer's aligment, which leads to UB.
Since a change in this method's signature requires a backward incompatible change, and it is only used in tests, I propose that we just remove it: we have good offers to create primitive arrays:
Currently, PrimitiveArray::new passed with
null_count != 0
creates an array that does not follow the specification, as it is initialized with aNone
null bitmap but a non-zero null_count.This method also makes no attempt to check for the buffer's aligment, which leads to UB.
Since a change in this method's signature requires a backward incompatible change, and it is only used in tests, I propose that we just remove it: we have good offers to create primitive arrays:
from an
ArrayData
,from a vector or vector of optionals
from an iterator
which covers all major cases.
Reporter: Jorge Leitão / @jorgecarleitao
Assignee: Jorge Leitão / @jorgecarleitao
PRs and other links:
Note: This issue was originally created as ARROW-10448. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: