[Release] JS package failing test prior to publish

[asfimport]

While trying to publish the JS, I am getting an error when running the tests (on mac).

To reproduce, run dev/release/post-05-js.sh 4.0.1 on branch release-arrow-4.0.1:

~/projects/arrow/apache-arrow-4.0.1/js ~/projects/arrow
yarn install v1.22.1
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
info google-closure-compiler-linux@20210406.0.0: The platform "darwin" is incompatible with this module.
info "google-closure-compiler-linux@20210406.0.0" is an optional dependency and failed compatibility check. Excluding it from installation.
info google-closure-compiler-windows@20210406.0.0: The platform "darwin" is incompatible with this module.
info "google-closure-compiler-windows@20210406.0.0" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] 🔗  Linking dependencies...
warning "lerna > @lerna/version > @lerna/github-client > @octokit/rest > @octokit/plugin-request-log@1.0.3" has unmet peer dependency "@octokit/core@>=3".
[5/5] 🔨  Building fresh packages...
warning Your current version of Yarn is out of date. The latest version is "1.22.5", while you're on "1.22.1".
info To upgrade, run the following command:
$ brew upgrade yarn
✨  Done in 121.72s.
yarn run v1.22.1
$ /Users/jorgecarleitao/projects/arrow/apache-arrow-4.0.1/js/node_modules/.bin/gulp
[05:39:21] Using gulpfile ~/projects/arrow/apache-arrow-4.0.1/js/gulpfile.js
[05:39:21] Starting 'default'...
[05:39:21] Starting 'clean'...
[05:39:21] Starting 'clean:ts'...
[05:39:21] Starting 'clean:apache-arrow'...
[05:39:21] Starting 'clean:es5:cjs'...
[05:39:21] Starting 'clean:es2015:cjs'...
[05:39:21] Starting 'clean:esnext:cjs'...
[05:39:21] Starting 'clean:es5:esm'...
[05:39:21] Starting 'clean:es2015:esm'...
[05:39:21] Starting 'clean:esnext:esm'...
[05:39:21] Starting 'clean:es5:cls'...
[05:39:21] Starting 'clean:es2015:cls'...
[05:39:21] Starting 'clean:esnext:cls'...
[05:39:21] Starting 'clean:es5:umd'...
[05:39:21] Starting 'clean:es2015:umd'...
[05:39:21] Starting 'clean:esnext:umd'...
[05:39:21] Finished 'clean:ts' after 211 ms
[05:39:21] Finished 'clean:apache-arrow' after 199 ms
[05:39:21] Finished 'clean:es5:cjs' after 195 ms
[05:39:21] Finished 'clean:es2015:cjs' after 196 ms
[05:39:21] Finished 'clean:esnext:cjs' after 190 ms
[05:39:21] Finished 'clean:es5:esm' after 180 ms
[05:39:21] Finished 'clean:es2015:esm' after 172 ms
[05:39:21] Finished 'clean:esnext:esm' after 169 ms
[05:39:21] Finished 'clean:es5:cls' after 151 ms
[05:39:21] Finished 'clean:es2015:cls' after 146 ms
[05:39:22] Finished 'clean:esnext:cls' after 163 ms
[05:39:22] Finished 'clean:es5:umd' after 149 ms
[05:39:22] Finished 'clean:es2015:umd' after 146 ms
[05:39:22] Finished 'clean:esnext:umd' after 142 ms
[05:39:22] Finished 'clean' after 293 ms
[05:39:22] Starting 'build'...
[05:39:22] Starting 'build:ts'...
[05:39:22] Starting 'build:apache-arrow'...
[05:39:22] Starting 'build:es5:cjs'...
[05:39:22] Starting 'clean:ts'...
[05:39:22] Starting 'clean:es5:cjs'...
[05:39:22] Finished 'clean:ts' after 728 μs
[05:39:22] Starting 'compile:ts'...
[05:39:22] Starting 'build:es2015:umd'...
[05:39:22] Starting 'build:esnext:cjs'...
[05:39:22] Starting 'build:esnext:esm'...
[05:39:22] Starting 'build:esnext:umd'...
[05:39:22] Finished 'clean:es5:cjs' after 11 ms
[05:39:22] Starting 'compile:es5:cjs'...
[05:39:22] Starting 'build:es2015:cls'...
[05:39:22] Starting 'clean:esnext:cjs'...
[05:39:22] Starting 'clean:esnext:esm'...
[05:39:22] Starting 'build:esnext:cls'...
[05:39:22] Starting 'clean:es2015:cls'...
[05:39:22] Finished 'clean:esnext:cjs' after 30 ms
[05:39:22] Starting 'compile:esnext:cjs'...
[05:39:22] Finished 'clean:esnext:esm' after 28 ms
[05:39:22] Starting 'compile:esnext:esm'...
[05:39:22] Starting 'clean:esnext:cls'...
[05:39:22] Finished 'clean:es2015:cls' after 53 ms
[05:39:22] Starting 'compile:es2015:cls'...
[05:39:22] Finished 'clean:esnext:cls' after 43 ms
[05:39:22] Starting 'compile:esnext:cls'...
[05:39:23] Finished 'compile:ts' after 1.37 s
[05:39:23] Starting 'package:ts'...
[05:39:23] Finished 'package:ts' after 56 ms
[05:39:23] Finished 'build:ts' after 1.45 s
[05:39:23] Starting 'build:es2015:cjs'...
[05:39:23] Starting 'clean:es2015:cjs'...
[05:39:23] Finished 'clean:es2015:cjs' after 12 ms
[05:39:23] Starting 'compile:es2015:cjs'...
[05:43:17] Finished 'compile:esnext:cls' after 3.9 min
[05:43:17] Starting 'package:esnext:cls'...
[05:43:17] Finished 'package:esnext:cls' after 114 ms
[05:43:17] Finished 'build:esnext:cls' after 3.92 min
[05:43:17] Starting 'clean:esnext:umd'...
[05:43:17] Finished 'clean:esnext:umd' after 5.44 ms
[05:43:17] Starting 'compile:esnext:umd'...
[05:43:20] Finished 'compile:es2015:cls' after 3.97 min
[05:43:20] Starting 'package:es2015:cls'...
[05:43:20] Finished 'package:es2015:cls' after 49 ms
[05:43:20] Finished 'build:es2015:cls' after 3.97 min
[05:43:20] Starting 'clean:es2015:umd'...
[05:43:20] Finished 'clean:es2015:umd' after 24 ms
[05:43:20] Starting 'compile:es2015:umd'...
[05:43:37] Finished 'compile:esnext:cjs' after 4.25 min
[05:43:37] Starting 'package:esnext:cjs'...
[05:43:37] Finished 'package:esnext:cjs' after 26 ms
[05:43:37] Finished 'build:esnext:cjs' after 4.25 min
[05:43:47] Finished 'compile:es2015:cjs' after 4.38 min
[05:43:47] Starting 'package:es2015:cjs'...
[05:43:47] Finished 'package:es2015:cjs' after 26 ms
[05:43:47] Finished 'build:es2015:cjs' after 4.38 min
[05:43:47] Starting 'build:esnext:cjs'...
[05:43:47] Starting 'clean:esnext:cjs'...
[05:43:47] Finished 'clean:esnext:cjs' after 247 μs
[05:43:47] Starting 'compile:esnext:cjs'...
[05:43:47] Finished 'compile:esnext:cjs' after 1.31 ms
[05:43:47] Starting 'package:esnext:cjs'...
[05:43:47] Finished 'package:esnext:cjs' after 548 μs
[05:43:47] Finished 'build:esnext:cjs' after 3.06 ms
[05:43:47] Starting 'build:es5:esm'...
[05:43:47] Starting 'clean:es5:esm'...
[05:43:47] Finished 'clean:es5:esm' after 270 μs
[05:43:47] Starting 'compile:es5:esm'...
[05:43:53] Finished 'compile:es5:cjs' after 4.52 min
[05:43:53] Starting 'package:es5:cjs'...
[05:43:53] Finished 'package:es5:cjs' after 26 ms
[05:43:53] Finished 'build:es5:cjs' after 4.52 min
[05:43:53] Starting 'build:es2015:esm'...
[05:43:53] Starting 'clean:es2015:esm'...
[05:43:53] Finished 'clean:es2015:esm' after 5.11 ms
[05:43:53] Starting 'compile:es2015:esm'...
[05:44:06] Finished 'compile:esnext:esm' after 4.73 min
[05:44:06] Starting 'package:esnext:esm'...
[05:44:07] Finished 'package:esnext:esm' after 28 ms
[05:44:07] Finished 'build:esnext:esm' after 4.73 min
[05:45:28] Finished 'compile:esnext:umd' after 2.18 min
[05:45:28] Starting 'package:esnext:umd'...
[05:45:28] Finished 'package:esnext:umd' after 26 ms
[05:45:28] Starting 'remove_closure_tmp_files'...
[05:45:28] Finished 'remove_closure_tmp_files' after 92 ms
[05:45:28] Finished 'build:esnext:umd' after 6.1 min
[05:45:31] Finished 'compile:es2015:umd' after 2.18 min
[05:45:31] Starting 'package:es2015:umd'...
[05:45:31] Finished 'package:es2015:umd' after 20 ms
[05:45:31] Starting 'remove_closure_tmp_files'...
[05:45:32] Finished 'remove_closure_tmp_files' after 169 ms
[05:45:32] Finished 'build:es2015:umd' after 6.17 min
[05:45:32] Starting 'clean:apache-arrow'...
[05:45:32] Finished 'clean:apache-arrow' after 16 ms
[05:45:32] Starting 'compile:apache-arrow'...
[05:45:34] Finished 'compile:apache-arrow' after 1.91 s
[05:45:34] Starting 'package:apache-arrow'...
[05:45:34] Finished 'package:apache-arrow' after 190 ms
[05:45:34] Finished 'build:apache-arrow' after 6.2 min
[05:45:34] Starting 'build:esnext:esm'...
[05:45:34] Starting 'clean:esnext:esm'...
[05:45:34] Finished 'clean:esnext:esm' after 3.45 ms
[05:45:34] Starting 'compile:esnext:esm'...
[05:45:34] Finished 'compile:esnext:esm' after 10 ms
[05:45:34] Starting 'package:esnext:esm'...
[05:45:34] Finished 'package:esnext:esm' after 5.95 ms
[05:45:34] Finished 'build:esnext:esm' after 38 ms
[05:45:34] Starting 'build:es5:cls'...
[05:45:34] Starting 'clean:es5:cls'...
[05:45:34] Finished 'clean:es5:cls' after 13 ms
[05:45:34] Starting 'compile:es5:cls'...
[05:46:36] Finished 'compile:es2015:esm' after 2.72 min
[05:46:36] Starting 'package:es2015:esm'...
[05:46:36] Finished 'package:es2015:esm' after 35 ms
[05:46:36] Finished 'build:es2015:esm' after 2.72 min
[05:46:36] Starting 'build:es2015:cls'...
[05:46:36] Starting 'clean:es2015:cls'...
[05:46:36] Finished 'clean:es2015:cls' after 7.41 ms
[05:46:36] Starting 'compile:es2015:cls'...
[05:46:36] Finished 'compile:es2015:cls' after 3.22 ms
[05:46:36] Starting 'package:es2015:cls'...
[05:46:36] Finished 'package:es2015:cls' after 4.4 ms
[05:46:36] Finished 'build:es2015:cls' after 22 ms
[05:46:36] Starting 'build:esnext:cls'...
[05:46:36] Starting 'clean:esnext:cls'...
[05:46:36] Finished 'clean:esnext:cls' after 2.01 ms
[05:46:36] Starting 'compile:esnext:cls'...
[05:46:36] Finished 'compile:esnext:cls' after 3.38 ms
[05:46:36] Starting 'package:esnext:cls'...
[05:46:36] Finished 'package:esnext:cls' after 4.54 ms
[05:46:36] Finished 'build:esnext:cls' after 29 ms
[05:46:36] Starting 'build:es5:umd'...
[05:46:36] Starting 'build:es5:cls'...
[05:46:36] Starting 'clean:es5:cls'...
[05:46:36] Finished 'clean:es5:cls' after 2.11 ms
[05:46:36] Starting 'compile:es5:cls'...
[05:46:40] Finished 'compile:es5:esm' after 2.88 min
[05:46:40] Starting 'package:es5:esm'...
[05:46:40] Finished 'package:es5:esm' after 13 ms
[05:46:40] Finished 'build:es5:esm' after 2.88 min
[05:46:40] Starting 'build:es2015:umd'...
[05:46:40] Starting 'build:es2015:cls'...
[05:46:40] Starting 'clean:es2015:cls'...
[05:46:40] Finished 'clean:es2015:cls' after 146 μs
[05:46:40] Starting 'compile:es2015:cls'...
[05:46:40] Finished 'compile:es2015:cls' after 162 μs
[05:46:40] Starting 'package:es2015:cls'...
[05:46:40] Finished 'package:es2015:cls' after 290 μs
[05:46:40] Finished 'build:es2015:cls' after 1.01 ms
[05:46:40] Starting 'clean:es2015:umd'...
[05:46:40] Finished 'clean:es2015:umd' after 157 μs
[05:46:40] Starting 'compile:es2015:umd'...
[05:46:40] Finished 'compile:es2015:umd' after 683 μs
[05:46:40] Starting 'package:es2015:umd'...
[05:46:40] Finished 'package:es2015:umd' after 590 μs
[05:46:40] Starting 'remove_closure_tmp_files'...
[05:46:40] Finished 'remove_closure_tmp_files' after 6.01 ms
[05:46:40] Finished 'build:es2015:umd' after 9.39 ms
[05:46:40] Starting 'build:esnext:umd'...
[05:46:40] Starting 'build:esnext:cls'...
[05:46:40] Starting 'clean:esnext:cls'...
[05:46:40] Finished 'clean:esnext:cls' after 158 μs
[05:46:40] Starting 'compile:esnext:cls'...
[05:46:40] Finished 'compile:esnext:cls' after 142 μs
[05:46:40] Starting 'package:esnext:cls'...
[05:46:40] Finished 'package:esnext:cls' after 279 μs
[05:46:40] Finished 'build:esnext:cls' after 979 μs
[05:46:40] Starting 'clean:esnext:umd'...
[05:46:40] Finished 'clean:esnext:umd' after 175 μs
[05:46:40] Starting 'compile:esnext:umd'...
[05:46:40] Finished 'compile:esnext:umd' after 134 μs
[05:46:40] Starting 'package:esnext:umd'...
[05:46:40] Finished 'package:esnext:umd' after 256 μs
[05:46:40] Starting 'remove_closure_tmp_files'...
[05:46:40] Finished 'remove_closure_tmp_files' after 3.67 ms
[05:46:40] Finished 'build:esnext:umd' after 5.89 ms
[05:46:58] Finished 'compile:es5:cls' after 1.38 min
[05:46:58] Starting 'package:es5:cls'...
[05:46:58] Finished 'compile:es5:cls' after 21 s
[05:46:58] Starting 'package:es5:cls'...
[05:46:58] Finished 'package:es5:cls' after 27 ms
[05:46:58] Finished 'build:es5:cls' after 1.38 min
[05:46:58] Finished 'package:es5:cls' after 27 ms
[05:46:58] Finished 'build:es5:cls' after 22 s
[05:46:58] Starting 'clean:es5:umd'...
[05:46:58] Finished 'clean:es5:umd' after 318 μs
[05:46:58] Starting 'compile:es5:umd'...
[05:47:37] Finished 'compile:es5:umd' after 39 s
[05:47:37] Starting 'package:es5:umd'...
[05:47:37] Finished 'package:es5:umd' after 74 ms
[05:47:37] Starting 'remove_closure_tmp_files'...
[05:47:37] Finished 'remove_closure_tmp_files' after 176 ms
[05:47:37] Finished 'build:es5:umd' after 1 min
[05:47:37] Finished 'build' after 8.25 min
[05:47:37] Starting 'test'...
[05:47:37] Starting 'test:ts'...
[05:47:37] Starting 'test:src'...
[05:47:37] Starting 'test:apache-arrow'...
ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
ts-jest[config] (WARN) There is a mismatch between your NodeJs version v12.14.0 and your TypeScript target esnext. This might lead to some unexpected errors when running tests with `ts-jest`. To fix this, you can check https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
ts-jest[config] (WARN) There is a mismatch between your NodeJs version v12.14.0 and your TypeScript target esnext. This might lead to some unexpected errors when running tests with `ts-jest`. To fix this, you can check https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
ts-jest[config] (WARN) There is a mismatch between your NodeJs version v12.14.0 and your TypeScript target esnext. This might lead to some unexpected errors when running tests with `ts-jest`. To fix this, you can check https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
ts-jest[ts-compiler] (WARN) test/jest-extensions.ts:34:5 - error TS2322: Type '<TActual extends AbstractVector<any> | [AbstractVector<any> | null, (string | undefined)?, (string | undefined)?], TExpected extends AbstractVector<any> | [AbstractVector<any> | null, (string | undefined)?]>(this: MatcherUtils, actual: TActual, expected: TExpected) => { pass: boolean; message: string; } | { pass: boolean; message: () => string; }' is not assignable to type 'CustomMatcher'.
  Type '{ pass: boolean; message: string; } | { pass: boolean; message: () => string; }' is not assignable to type 'CustomMatcherResult | Promise<CustomMatcherResult>'.
    Type '{ pass: boolean; message: string; }' is not assignable to type 'CustomMatcherResult | Promise<CustomMatcherResult>'.
      Type '{ pass: boolean; message: string; }' is not assignable to type 'CustomMatcherResult'.
        Types of property 'message' are incompatible.
          Type 'string' is not assignable to type '() => string'.

34     toEqualVector,
       ~~~~~~~~~~~~~

  node_modules/@types/jest/index.d.ts:538:9
    538         [key: string]: CustomMatcher;
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    The expected type comes from this index signature.

  ● should close the underlying NodeJS ReadableStream when reading multiple tables and we break early

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      215 | function validateStreamState(reader: RecordBatchReader, stream: NodeJS.ReadableStream, closed: boolean, readable = !closed) {
      216 |     expect(reader.closed).toBe(closed);
    > 217 |     expect(Boolean(stream.readable)).toBe(readable);
          |                                      ^
      218 |     expect(Boolean((stream as any).destroyed)).toBe(closed);
      219 |     expect(Boolean((stream as any).readableFlowing)).toBe(false);
      220 | }

      at validateStreamState (test/unit/ipc/reader/streams-node-tests.ts:217:38)
      at Object.<anonymous> (test/unit/ipc/reader/streams-node-tests.ts:210:9)
          at runMicrotasks (<anonymous>)


  ● should close the underlying NodeJS ReadableStream when reading multiple tables and we break early

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      215 | function validateStreamState(reader: RecordBatchReader, stream: NodeJS.ReadableStream, closed: boolean, readable = !closed) {
      216 |     expect(reader.closed).toBe(closed);
    > 217 |     expect(Boolean(stream.readable)).toBe(readable);
          |                                      ^
      218 |     expect(Boolean((stream as any).destroyed)).toBe(closed);
      219 |     expect(Boolean((stream as any).readableFlowing)).toBe(false);
      220 | }

      at validateStreamState (test/unit/ipc/reader/streams-node-tests.ts:217:38)
      at Object.<anonymous> (test/unit/ipc/reader/streams-node-tests.ts:210:9)
          at runMicrotasks (<anonymous>)


  ● should close the underlying NodeJS ReadableStream when reading multiple tables and we break early

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      215 | function validateStreamState(reader: RecordBatchReader, stream: NodeJS.ReadableStream, closed: boolean, readable = !closed) {
      216 |     expect(reader.closed).toBe(closed);
    > 217 |     expect(Boolean(stream.readable)).toBe(readable);
          |                                      ^
      218 |     expect(Boolean((stream as any).destroyed)).toBe(closed);
      219 |     expect(Boolean((stream as any).readableFlowing)).toBe(false);
      220 | }

      at validateStreamState (test/unit/ipc/reader/streams-node-tests.ts:217:38)
      at Object.<anonymous> (test/unit/ipc/reader/streams-node-tests.ts:210:9)
          at runMicrotasks (<anonymous>)

[05:51:42] 'test:apache-arrow' errored after 4.07 min
[05:51:42] Error: exited with error code: 1
    at ChildProcess.onexit (/Users/jorgecarleitao/projects/arrow/apache-arrow-4.0.1/js/node_modules/end-of-stream/index.js:40:36)
    at ChildProcess.emit (events.js:210:5)
    at ChildProcess.EventEmitter.emit (domain.js:498:23)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
[05:51:42] 'test' errored after 4.07 min
[05:51:42] 'default' errored after 12 min
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Reporter: Jorge Leitão / @jorgecarleitao
Assignee: Kouhei Sutou / @kou

_{Note: This issue was originally created as ARROW-13046. Please see the migration documentation for further details.}

[asfimport]

Jorge Leitão / @jorgecarleitao:
@domoritz, could you guide me here?

Even if I ignore the tests and proceed, I am getting

yarn run v1.22.1
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
$ lerna exec npm publish
lerna notice cli v3.22.1
lerna ERR! ENOLERNA `lerna.json` does not exist, have you run `lerna init`?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

It seems that lerna requires a version in lerna.json? Can I just write 0.0.0? I tried using "version": "4.0.0", but I am getting that

npm notice === Tarball Contents === 
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.yarnpkg.com/@apache-arrow%2fes2015-umd - Not found
npm ERR! 404 
npm ERR! 404  '@apache-arrow/es2015-umd@4.0.0' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

(even after npm login).

I am a collaborator of apache-arrow in npm, so I should have permissions to do this.

[asfimport]

Dominik Moritz / @domoritz:
Could you try adding this commit: 3a6f605 (with an updated version to 4.0.1)?The lerna.json file should exist in the js directory. Make sure that you are in the directory.

[asfimport]

Jorge Leitão / @jorgecarleitao:
Thanks @domoritz and [~paul.e.taylor], I cherry-picked that commit on top of the release/4.0.1, but the same problem remains.

Note that I am already using

cd js && ./npm-release.sh

directly, so that we build from the current checked out code (as opposed to dev/release/post-05-js.sh that checkouts a clean version from github).

[asfimport]

Kouhei Sutou / @kou:
Published.

I needed to be logged in to registry.yarnpkg.com not registry.npmjs.org: npm login --registry=https://registry.yarnpkg.com/

[asfimport]

Kouhei Sutou / @kou:
I've updated https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide .