Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Format] Make requirement around dense union offsets less ambiguous #18760

Open
asfimport opened this issue Jul 28, 2021 · 3 comments
Open

[Format] Make requirement around dense union offsets less ambiguous #18760

asfimport opened this issue Jul 28, 2021 · 3 comments

Comments

@asfimport
Copy link

Currently, the spec states that dense union offsets for each child array must be "in order / increasing". There is an ambiguity: should they be strictly increasing, or are equal values supported?

The C++ implementation currently considers that equal offsets are acceptable.

 

Reporter: Antoine Pitrou / @pitrou

Note: This issue was originally created as ARROW-13479. Please see the migration documentation for further details.

@asfimport
Copy link
Author

@asfimport
Copy link
Author

Micah Kornfield / @emkornfield:
Hmm, I would have thought strictly, but I don't know the implications of changing it at this point.

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Same opinion. We should probably be conservative. @wesm What do you say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant