Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Clean up cmake CXX_STANDARD and PIC flag setting #19109

Closed
asfimport opened this issue Jun 18, 2018 · 2 comments
Closed

[C++] Clean up cmake CXX_STANDARD and PIC flag setting #19109

asfimport opened this issue Jun 18, 2018 · 2 comments

Comments

@asfimport
Copy link

We're using -std=c++11 in a few non-external project places as well as setting -fPIC. CMake provides the CMAKE_CXX_STANDARD flag (which we are also using) and the CMAKE_POSITION_INDEPENDENT_CODE flag for setting these options in a cross platform way (where it matters).

We should use these flags instead of using platform conditional checks to set their values explicitly.

Reporter: Phillip Cloud / @cpcloud
Assignee: Wes McKinney / @wesm

PRs and other links:

Note: This issue was originally created as ARROW-2720. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Definitely would be good to use the CMAKE_* stuff where we have control over it. We'll still have to pass -fPIC to some of the external projects, but we could handle that in ThirdpartyToolchain.cmake

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 2995
#2995

@asfimport asfimport added this to the 0.12.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants