You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're using -std=c++11 in a few non-external project places as well as setting -fPIC. CMake provides the CMAKE_CXX_STANDARD flag (which we are also using) and the CMAKE_POSITION_INDEPENDENT_CODE flag for setting these options in a cross platform way (where it matters).
We should use these flags instead of using platform conditional checks to set their values explicitly.
Wes McKinney / @wesm:
Definitely would be good to use the CMAKE_* stuff where we have control over it. We'll still have to pass -fPIC to some of the external projects, but we could handle that in ThirdpartyToolchain.cmake
We're using
-std=c++11
in a few non-external project places as well as setting-fPIC
. CMake provides theCMAKE_CXX_STANDARD
flag (which we are also using) and theCMAKE_POSITION_INDEPENDENT_CODE
flag for setting these options in a cross platform way (where it matters).We should use these flags instead of using platform conditional checks to set their values explicitly.
Reporter: Phillip Cloud / @cpcloud
Assignee: Wes McKinney / @wesm
PRs and other links:
Note: This issue was originally created as ARROW-2720. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: