Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Plasma Seal is slow due to hashing #19283

Closed
asfimport opened this issue Jul 25, 2018 · 1 comment
Closed

[C++] Plasma Seal is slow due to hashing #19283

asfimport opened this issue Jul 25, 2018 · 1 comment

Comments

@asfimport
Copy link

When I writes a 1MB tensor into plasma, it takes about 2ms. 50% of time is spent sealing the object. Can we add a flag to the Seal API to disable to hashing when needed?

 

For example:

 Status PlasmaClient::Seal(const ObjectID& object_id, bool hash_flag)

 

cc @pcmoritz

Reporter: Simon Mo / @simon-mo

Note: This issue was originally created as ARROW-2916. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Robert Nishihara / @robertnishihara:
In my experience, profilers often show the hashing taking up a bunch of time, but when I actually comment out the hashing, things don't get faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant