Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Thrift compiler reruns in arrow/dbi/hiveserver2/thrift when using Ninja build #19493

Closed
asfimport opened this issue Aug 30, 2018 · 3 comments
Assignees
Milestone

Comments

@asfimport
Copy link

I've spent some time trying to figure out why this is, playing with different dependency orderings and file properties.

I don't see why this command is fundamentally different from our Flatbuffers-generated files which are basically doing the same thing

https://github.com/apache/arrow/blob/master/cpp/src/arrow/dbi/hiveserver2/thrift/CMakeLists.txt#L65

The code to generate the Thrift bindings originally came from Impala so there might be some small bug. We could take a look if the bug is present in Impala (with Ninja) and see if not, see how what they have is different and if that will fix it

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

Note: This issue was originally created as ARROW-3145. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Seems like some kind of "touch" workaround could be employed as a last resort similar to https://stackoverflow.com/questions/41597612/add-custom-command-does-not-re-run-on-failure (not portable to Windows though)

@asfimport
Copy link
Author

Wes McKinney / @wesm:
I fixed this in my flight-cpp-prototype branch, will resolve this once that is merged

@asfimport
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants