Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Programmatically created dictionary vectors don't get dictionary IDs #19751

Closed
asfimport opened this issue Oct 3, 2018 · 1 comment
Closed

Comments

@asfimport
Copy link

This seems to be the cause of the test failures in #2322

Modifying getSingleRecordBatchTable to generate its vectors programmatically (rather than deserializing hard-coded JSON), causes the new round-trip tests added in #2638 to fail. The root cause seems to be that an ID is never allocated for the generated dictionary.

Reporter: Brian Hulette / @TheNeuralBit
Assignee: Brian Hulette / @TheNeuralBit

PRs and other links:

Note: This issue was originally created as ARROW-3425. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 2726
#2726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants