Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Support for writing TIMESTAMP_NANOS Parquet metadata #20028

Closed
asfimport opened this issue Nov 8, 2018 · 3 comments
Closed

[C++] Support for writing TIMESTAMP_NANOS Parquet metadata #20028

asfimport opened this issue Nov 8, 2018 · 3 comments

Comments

@asfimport
Copy link

asfimport commented Nov 8, 2018

This was brought up on the mailing list.

We also will need to do corresponding work in the parquet-cpp library to opt in to writing nanosecond timestamps instead of casting to micro- or millisecond.

Reporter: Wes McKinney / @wesm
Assignee: TP Boudreau / @tpboudreau

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-3729. Please see the migration documentation for further details.

@asfimport
Copy link
Author

TP Boudreau / @tpboudreau:
Could someone please assign this issue to me? I don't seem to be able to claim it myself. Thanks.

The enhancement I'm contemplating (and have largely completed) involves switching over to using (that is, generating on write, recognizing on read) the new parquet.thrift LogicalType (aka "annotation") metadata recently introduced into parquet-cpp (see PARQUET-1411).  Thus the patch will be broader than just adding nanosecond units to timestamps, but will include that.

 

@asfimport
Copy link
Author

Uwe Korn / @xhochy:
@tpboudreau assigned to you and also gave you the permissions so that you can do it by yourself.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 4421
#4421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant