Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add type inference for boolean values in CSV files #20162

Closed
asfimport opened this issue Nov 14, 2018 · 6 comments
Closed

[C++] Add type inference for boolean values in CSV files #20162

asfimport opened this issue Nov 14, 2018 · 6 comments

Comments

@asfimport
Copy link

Reporter: Kouhei Sutou / @kou
Assignee: Antoine Pitrou / @pitrou

PRs and other links:

Note: This issue was originally created as ARROW-3791. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
This is handled in ARROW-3722 (see pull request: #2950). You will be able to specify data types for each column, including BooleanType().

@asfimport
Copy link
Author

Wes McKinney / @wesm:
He's asking for type inference I think based on the discussion in the PR

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Hmm... I don't know if that's a good idea. But I'll reopen the issue and fix the title.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
It wouldn't be too harmful if the default recognized T/F values are a conservative set like "true"/"false" or "TRUE"/"FALSE". We might collect data on what other projects do in this regard. I would opt for developer control, though, so this might be something we make configurable (whether type inferences tries boolean by default or not)

@asfimport
Copy link
Author

Kouhei Sutou / @kou:
Yes. I want type inference for boolean. Sorry for my ambiguous title.

I think that specifying type explicitly is very useful. But type inference is also useful even if it may choose wrong type because it's convenient. If type inference is failed, we can specify type explicitly. It's convenience than we specify all types explicitly.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 4055
#4055

@asfimport asfimport added this to the 0.14.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants