[C++][Benchmarks] Create Asof Join Benchmark for Acero

[asfimport]

Reporter: Ivan Chau / @iChauster
Assignee: Ivan Chau / @iChauster

PRs and other links:

• GitHub Pull Request #13426

_{Note: This issue was originally created as ARROW-16894. Please see the migration documentation for further details.}

[asfimport]

Ivan Chau / @iChauster:
Hi @westonpace,

Left some questions for you on the PR, would love to hear your advice!

Thanks for the help!

[asfimport]

Weston Pace / @westonpace:
Issue resolved by pull request 13426
#13426

[asfimport]

Aldrin Montana / @drin:
@iChauster, I tried to run this benchmark but I see this error:

./debug/arrow-compute-asof-join-benchmark
/Users/octalene/builds/arrow-dev/dev/gbenchmark_ep-prefix/src/gbenchmark_ep/src/benchmark_register.cc:314: Args: Check `ArgsCnt() == -1 || ArgsCnt() == static_cast<int>(args.size())' failed.
fish: Job 1, './debug/arrow-compute-asof-join…' terminated by signal SIGABRT (Abort)

After I make the following change:

--- a/cpp/src/arrow/compute/exec/asof_join_benchmark.cc
+++ b/cpp/src/arrow/compute/exec/asof_join_benchmark.cc
@@ -157,7 +157,7 @@ void SetArgs(benchmark::internal::Benchmark* bench) {
   }
 }

-BENCHMARK(AsOfJoinOverhead)->Apply(SetArgs);
+BENCHMARK(AsOfJoinOverhead);

 }  // namespace compute
 }  // namespace arrow

I see this error:

***WARNING*** Library was built as DEBUG. Timings may be affected.
Assertion failed: (range_.size() > pos), function range, file benchmark.h, line 664.
fish: Job 1, './debug/arrow-compute-asof-join…' terminated by signal SIGABRT (Abort)

I didn't read through the PR, but I just wanted to drop this note here in case it's not just a me thing. I'm on an M1 mac mini, haven't tried on anything else. And this should be on master branch. I suspect there's an extra thing to do to run the benchmark (I assume there's a reason the ->Apply breaks for me), I just don't know what it is.