Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Merge script could warn if username pings would be present in commit message #20313

Closed
asfimport opened this issue Jul 8, 2022 · 3 comments

Comments

@asfimport
Copy link

asfimport commented Jul 8, 2022

If a PR gets merged and its description @ references a user, then the user will get a GitHub notification every time that commit gets pushed to a fork. This can be rather a bother, so it might be nice if the merge script could warn about this, or possibly even rewrite the commit message.

Reporter: David Li / @lidavidm
Assignee: Joris Van den Bossche / @jorisvandenbossche
Watchers: Rok Mihevc / @rok

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-17025. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Rok Mihevc / @rok:
So something like this?

re.sub("@(\w+)", "@ \\1", commit_message) 

@asfimport
Copy link
Author

Joris Van den Bossche / @jorisvandenbossche:
Adding a space like that sounds as a good solution, will put that in a PR.

@asfimport
Copy link
Author

Rok Mihevc / @rok:
Issue resolved by pull request 14458
#14458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants