Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] arrow-compute-asof-join-node-test inordinately slow #20406

Closed
asfimport opened this issue Sep 13, 2022 · 7 comments
Closed

[C++] arrow-compute-asof-join-node-test inordinately slow #20406

asfimport opened this issue Sep 13, 2022 · 7 comments

Comments

@asfimport
Copy link
Collaborator

It seems that arrow-compute-asof-join-node-test is designed such as each sub-test takes 2 seconds. The entire test file takes 120 seconds here.

This is much too slow for a single test file and should drastically be reduced.

Reporter: Antoine Pitrou / @pitrou
Assignee: Yaron Gvili / @rtpsw

PRs and other links:

Note: This issue was originally created as ARROW-17696. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

@asfimport
Copy link
Collaborator Author

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
@rtpsw Could you take a look and try to improve things here?

@asfimport
Copy link
Collaborator Author

Yaron Gvili / @rtpsw:
IIRC, at the time, I asked about the timeout for this test, and the answer was something like 300 seconds. How much do we want it to be? I can set  it rather flexibly.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
300 seconds might be the timeout set on CI in case a test is stuck, but a test file shouldn't certainly not come near that duration.

10 seconds max would be a reasonable target IMHO.

@asfimport
Copy link
Collaborator Author

Yaron Gvili / @rtpsw:
Note that I'll set the timeout at the test-case level, not for the entire test executable. I'll cut it down by a factor of 10.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 14190
#14190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant