Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add fallback for shorthand Substrait URIs without scheme #20412

Closed
asfimport opened this issue Sep 15, 2022 · 1 comment
Closed

[C++] Add fallback for shorthand Substrait URIs without scheme #20412

asfimport opened this issue Sep 15, 2022 · 1 comment

Comments

@asfimport
Copy link

At the moment there is no agreed URI base for the standard Substrait functions. The Substrait consumer is currently expecting https://github.com/substrait-io/substrait/blob/main/extensions/FILENAME.YAML but Isthmus is currently generating /FILENAME.YAML.

Although this is a short-term problem I could imagine it popping up again from time to time when users are developing their own functions. So, as a workaround, I suggest that any URI equal to the empty string or "/" should be treated as a "shortcut" and we fall back to name-only matching.

Reporter: Weston Pace / @westonpace
Assignee: Weston Pace / @westonpace

PRs and other links:

Note: This issue was originally created as ARROW-17736. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Weston Pace / @westonpace:
Issue resolved by pull request 14143
#14143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants