Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Use atomic backpressure counter #20495

Closed
asfimport opened this issue Nov 11, 2022 · 1 comment
Closed

[C++] Use atomic backpressure counter #20495

asfimport opened this issue Nov 11, 2022 · 1 comment

Comments

@asfimport
Copy link

There are a few places in the code (sink_node.cc, source_node.cc, file_base.cc) where the backpressure counter is of type int32_t. This prevents ExecNode::Pause(...) and  ExecNode::Resume(...) from being thread-safe. The proposal is to make these backpressure counters be of type std::atomic<int32_t>.

Reporter: Yaron Gvili / @rtpsw
Assignee: Yaron Gvili / @rtpsw

PRs and other links:

Note: This issue was originally created as ARROW-18310. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Weston Pace / @westonpace:
Issue resolved by pull request 14622
#14622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant