Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Run Gandiva tests on Windows and Appveyor #21004

Closed
asfimport opened this issue Feb 1, 2019 · 4 comments
Closed

[Python] Run Gandiva tests on Windows and Appveyor #21004

asfimport opened this issue Feb 1, 2019 · 4 comments

Comments

@asfimport
Copy link

Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney / @wesm

PRs and other links:

Note: This issue was originally created as ARROW-4446. Please see the migration documentation for further details.

@asfimport
Copy link
Author

shyam narayan singh / @shyambits2004:
For the timezone implementation, we are using the operating systems timezone database. For windows, the expectation is IANA database is downloaded into the required location as specified below.

REF : https://howardhinnant.github.io/date/tz.html

  1. USE_OS_TZDB : If USE_OS_TZDB is 1 then this library will use the zic-compiled time zone database provided by your OS. This option relieves you of having to install the IANA time zone database, either manually, or automatically with AUTO_DOWNLOAD. This option is not available on Windows.

2. If the macro INSTALL is not defined, the default location of the database is ~/Downloads/tzdata(%homedrive%\%homepath%\downloads zdata on Windows).

3. On Windows, HAS_REMOTE_API defaults to 0. Everywhere else it defaults to 1. This is because libcurl comes preinstalled everywhere but Windows, but it is available for Windows.

  1. If you want to enable HAS_REMOTE_API and/or AUTO_DOWNLOAD on Windows you will have to manually install curl and 7-zip into their default locations.

  2. If you do not enable HAS_REMOTE_API, you will need to also install http://unicode.org/repos/cldr/trunk/common/supplemental/windowsZones.xml into your install location. This will be done for you if you have enabled HAS_REMOTE_API and let AUTO_DOWNLOAD default to 1.

@asfimport
Copy link
Author

Pindikura Ravindra / @pravindra:
@shyambits2004 can you open a new Jira for fixing the date/tz issue on windows ? Till that's fixed, we could disable the test on windows.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
OK, I will do that.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 3567
#3567

@asfimport asfimport added this to the 0.13.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants