[C++] DCHECK macro conditions are evaluated in release builds

[asfimport]

DCHECK(potentially_expensive()) will evaluate the argument even in release mode, and is used in several places with the assumption that it will do so (which means removing the guarantee of evaluation causes numerous failures). By contrast, most debug assertion macros elide their arguments entirely (<cassert>.assert, <glog/logging.h>) in release mode

Reporter: Ben Kietzman / @bkietz
Assignee: Wes McKinney / @wesm

PRs and other links:

• GitHub Pull Request #3854

_{Note: This issue was originally created as ARROW-4664. Please see the migration documentation for further details.}

[asfimport]

Wes McKinney / @wesm:
I think this is a rather serious issue actually.

[asfimport]

Wes McKinney / @wesm:
Issue resolved by pull request 3854
#3854