Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Implement AssertDatumEquals #21203

Closed
asfimport opened this issue Feb 25, 2019 · 3 comments
Closed

[C++] Implement AssertDatumEquals #21203

asfimport opened this issue Feb 25, 2019 · 3 comments

Comments

@asfimport
Copy link

Aggregate tests could benefit from this.

Reporter: Francois Saint-Jacques / @fsaintjacques
Assignee: Francois Saint-Jacques / @fsaintjacques

PRs and other links:

Note: This issue was originally created as ARROW-4673. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
[~emkornfield@gmail.com] replied on the mailing list "It might be nice to do this as a Gmock matcher instead of a separate macro"

@asfimport
Copy link
Author

Francois Saint-Jacques / @fsaintjacques:
We will need ToString methods for every sub-objects to use Matchers. A second note on this, while debugging it's very handy if the Matcher can pin-point the exact reason, e.g. row, where the miss-match happens.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 3875
#3875

@asfimport asfimport added this to the 0.13.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants