Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Docs] Clarify expectation of UTC values for timestamps with time zones in C++ API docs #21991

Closed
asfimport opened this issue Jun 10, 2019 · 4 comments

Comments

@asfimport
Copy link
Collaborator

For timestamp datatypes, if the timezone parameter is non-empty, the int64 array values in the associated column are assumed to be normalized to UTC.  This requirement should be made clear to the C++ API user.  (It can be inferred from the flatbuffers schema, but that internal implementation document probably wouldn't ordinarily be consulted by a C++ API consumer.)

Reporter: TP Boudreau / @tpboudreau
Assignee: TP Boudreau / @tpboudreau

PRs and other links:

Note: This issue was originally created as ARROW-5545. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

TP Boudreau / @tpboudreau:
On further review, the flatbuffers spec contains quite a bit of usage information and probably is intended to be a primary resource for developers.  (Sorry for the noise.)

Closing this issue.

@asfimport
Copy link
Collaborator Author

Wes McKinney / @wesm:
Reopening. I think the C++ header files should make it clear what is expected, this seems like an opportunity to improve them

@asfimport
Copy link
Collaborator Author

TP Boudreau / @tpboudreau:
OK, I've re-assigned to myself.

@asfimport
Copy link
Collaborator Author

Wes McKinney / @wesm:
Issue resolved by pull request 4555
#4555

@asfimport asfimport added this to the 0.14.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant