We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now in DictionaryEncoder#encode it use reflection to pull out the set method and then set values.
Set values by reflection is not efficient and code structure is not elegant such as
Method setter = null; for (Class<?> c : Arrays.asList(int.class, long.class)) { try { setter = indices.getClass().getMethod("setSafe", int.class, c); break; } catch (NoSuchMethodException e) { // ignore } }
Implement a common interface for int vectors to directly get set method and set values seems a good choice.
Reporter: Ji Liu / @tianchen92 Assignee: Ji Liu / @tianchen92
Note: This issue was originally created as ARROW-5726. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered:
Micah Kornfield / @emkornfield: Issue resolved by pull request 4698 #4698
Sorry, something went wrong.
tianchen92
No branches or pull requests
Now in DictionaryEncoder#encode it use reflection to pull out the set method and then set values.
Set values by reflection is not efficient and code structure is not elegant such as
Method setter = null;
for (Class<?> c : Arrays.asList(int.class, long.class)) {
try {
setter = indices.getClass().getMethod("setSafe", int.class, c);
break;
} catch (NoSuchMethodException e) {
// ignore
}
}
Implement a common interface for int vectors to directly get set method and set values seems a good choice.
Reporter: Ji Liu / @tianchen92
Assignee: Ji Liu / @tianchen92
PRs and other links:
Note: This issue was originally created as ARROW-5726. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: