Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Refactor Jdbc adapter consume logic #22482

Closed
asfimport opened this issue Jul 31, 2019 · 2 comments
Closed

[Java] Refactor Jdbc adapter consume logic #22482

asfimport opened this issue Jul 31, 2019 · 2 comments

Comments

@asfimport
Copy link

Jdbc adapter read from ResultSet looks like:

while (rs.next()) {
for (int i = 1; i <= columnCount; i++) {
jdbcToFieldVector(
rs,
i,
rs.getMetaData().getColumnType(i),
rowCount,
root.getVector(rsmd.getColumnName(i)),
config);
}
rowCount++;
}

And in jdbcToFieldVector has lots of switch-case, that is to see, for every single value from ResultSet we have to do lots of analyzing conditions.

I think we could optimize this using consumer/delegate like avro adapter.

Reporter: Ji Liu / @tianchen92
Assignee: Ji Liu / @tianchen92

PRs and other links:

Note: This issue was originally created as ARROW-6083. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Micah Kornfield / @emkornfield:
Issue resolved by pull request 4978
#4978

@asfimport
Copy link
Author

Ji Liu / @tianchen92:
[~emkornfield@gmail.com] Thanks for your effort and sorry for always forgetting to specify the module :)

@asfimport asfimport added this to the 0.15.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants