We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently ApproxEqualsVisitor will accept a epsilon for both float and double compare, and the difference calculation is always Math.abs(f1-f2)
ApproxEqualsVisitor
Math.abs
For some cases like Validator it is not very suitable as:
Validator
i. it has different epsilon values for float/double
ii. it difference function is not Math.abs(f1-f2)
To resolve these, make this visitor accept both float/double epsilons and diff functions.
Reporter: Ji Liu / @tianchen92 Assignee: Ji Liu / @tianchen92
Note: This issue was originally created as ARROW-6311. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered:
Pindikura Ravindra / @pravindra: Issue resolved by pull request 5155 #5155
Sorry, something went wrong.
tianchen92
No branches or pull requests
Currently
ApproxEqualsVisitor
will accept a epsilon for both float and double compare, and the difference calculation is alwaysMath.abs
(f1-f2)For some cases like
Validator
it is not very suitable as:i. it has different epsilon values for float/double
ii. it difference function is not Math.abs(f1-f2)
To resolve these, make this visitor accept both float/double epsilons and diff functions.
Reporter: Ji Liu / @tianchen92
Assignee: Ji Liu / @tianchen92
PRs and other links:
Note: This issue was originally created as ARROW-6311. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: