Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Remove unused hashing routines #22837

Closed
asfimport opened this issue Sep 5, 2019 · 1 comment
Closed

[C++] Remove unused hashing routines #22837

asfimport opened this issue Sep 5, 2019 · 1 comment
Assignees
@pitrou
Labels
Component: C++ Type: task
Milestone
0.16.0

Comments

@asfimport
Copy link

The adoption of xxh3 for hashing (in ARROW-6385) probably left around some specialized but unused hashing functions (e.g. CRC-based hashing, perhaps also murmurhash). We should probably remove them if no problem surfaces with xxh3.

Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou / @pitrou

PRs and other links:

Note: This issue was originally created as ARROW-6468. Please see the migration documentation for further details.
@asfimport
Copy link
Author

Wes McKinney / @wesm:
Issue resolved by pull request 5591
#5591

@asfimport asfimport added this to the 0.16.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Type: task
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
2 participants
@pitrou @asfimport