Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] boost::optional in STL test fails compiling in gcc 4.8.2 #22912

Closed
asfimport opened this issue Sep 12, 2019 · 4 comments
Closed

[C++] boost::optional in STL test fails compiling in gcc 4.8.2 #22912

asfimport opened this issue Sep 12, 2019 · 4 comments

Comments

@asfimport
Copy link

asfimport commented Sep 12, 2019

Quoting @bkietz from mailgroup:

a tuple constructor is choking on implicit conversion from
string literal (char[6]) to boost::optional<std::string>

Reporter: Omer Ozarslan / @ozars
Assignee: Omer Ozarslan / @ozars

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-6552. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Omer Ozarslan / @ozars:
Is there a simple way (such as Dockerfile) to test changes on gcc 4.8.2?

@asfimport
Copy link
Author

Ben Kietzman / @bkietz:
You can run the docker image which failed (working directory is arrow root):

$ docker run \
  -v $PWD:/arrow \
  -v $PWD:/io \
  quay.io/praveenbingo/arrow:buildGandivaDocker \
  /io/dev/tasks/gandiva-jars/build-cpp-linux.sh

(lifted from https://travis-ci.org/ursa-labs/crossbow/builds/582833123#L489 )

@asfimport
Copy link
Author

Ben Kietzman / @bkietz:
Easier: use @ursabot comments #5369 (comment)

@asfimport
Copy link
Author

Ben Kietzman / @bkietz:
Issue resolved by pull request 5369
#5369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant