Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Simplify transitive component dependencies #23187

Closed
asfimport opened this issue Oct 11, 2019 · 1 comment
Closed

[C++] Simplify transitive component dependencies #23187

asfimport opened this issue Oct 11, 2019 · 1 comment

Comments

@asfimport
Copy link
Collaborator

In the C++ build system, we are handling relationships between optional components in an ad hoc fashion

if(ARROW_BUILD_TESTS OR ARROW_BUILD_BENCHMARKS)

This doesn't seem ideal.

As discussed on the mailing list, I suggest declaring dependencies in a Python data structure and then generating and checking in a .cmake file that can be included. This will be a big easier than maintaining this on an ad hoc basis.

Reporter: Wes McKinney / @wesm
Assignee: Kouhei Sutou / @kou

PRs and other links:

Note: This issue was originally created as ARROW-6858. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Yibo Cai / @cyb70289:
Issue resolved by pull request 14224
#14224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants