Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go][Integration] Decimal integration failures #24167

Closed
asfimport opened this issue Feb 26, 2020 · 3 comments
Closed

[Go][Integration] Decimal integration failures #24167

asfimport opened this issue Feb 26, 2020 · 3 comments

Comments

@asfimport
Copy link
Collaborator

asfimport commented Feb 26, 2020

If I un-skip decimal data for integrations tests with Go, I get some errors such as:

==========================================================
Testing file /tmp/tmpkz1_ydgp/generated_decimal.json
==========================================================
-- Creating binary inputs
-- Validating file
Traceback (most recent call last):
  File "/arrow/dev/archery/archery/integration/util.py", line 130, in run_cmd
    output = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
  File "/opt/conda/envs/arrow/lib/python3.8/subprocess.py", line 411, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/opt/conda/envs/arrow/lib/python3.8/subprocess.py", line 512, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/opt/go/bin/arrow-json-integration-test', '-arrow', '/tmp/tmpj9b4jgvi/10cae236_generated_decimal.json_as_file', '-json', '/tmp/tmpkz1_ydgp/generated_decimal.json', '-mode', 'VALIDATE']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/arrow/dev/archery/archery/integration/runner.py", line 193, in _run_ipc_test_case
    run_binaries(producer, consumer, outcome, test_case)
  File "/arrow/dev/archery/archery/integration/runner.py", line 219, in _produce_consume
    consumer.validate(json_path, producer_file_path)
  File "/arrow/dev/archery/archery/integration/tester_go.py", line 55, in validate
    return self._run(arrow_path, json_path, 'VALIDATE')
  File "/arrow/dev/archery/archery/integration/tester_go.py", line 52, in _run
    run_cmd(cmd)
  File "/arrow/dev/archery/archery/integration/util.py", line 139, in run_cmd
    raise RuntimeError(sio.getvalue())
RuntimeError: Command failed: ['/opt/go/bin/arrow-json-integration-test', '-arrow', '/tmp/tmpj9b4jgvi/10cae236_generated_decimal.json_as_file', '-json', '/tmp/tmpkz1_ydgp/generated_decimal.json', '-mode', 'VALIDATE']
With output:
--------------
arrow-json: could not open JSON file reader from file "/tmp/tmpkz1_ydgp/generated_decimal.json": json: cannot unmarshal number into Go struct field dataType.precision of type string

--------------

Reporter: Antoine Pitrou / @pitrou
Assignee: Matthew Topol / @zeroshade

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-7948. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Even Go-with-Go doesn't work:

FAILED TEST: decimal Go producing,  Go consuming
Traceback (most recent call last):
  File "/arrow/dev/archery/archery/integration/util.py", line 130, in run_cmd
    output = subprocess.check_output(cmd, stderr=subprocess.STDOUT)
  File "/opt/conda/envs/arrow/lib/python3.8/subprocess.py", line 411, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/opt/conda/envs/arrow/lib/python3.8/subprocess.py", line 512, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/opt/go/bin/arrow-json-integration-test', '-arrow', '/tmp/tmpj9b4jgvi/fd6cfe16_generated_decimal.json_as_file', '-json', '/tmp/tmpkz1_ydgp/generated_decimal.json', '-mode', 'JSON_TO_ARROW']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/arrow/dev/archery/archery/integration/runner.py", line 193, in _run_ipc_test_case
    run_binaries(producer, consumer, outcome, test_case)
  File "/arrow/dev/archery/archery/integration/runner.py", line 215, in _produce_consume
    producer.json_to_file(json_path, producer_file_path)
  File "/arrow/dev/archery/archery/integration/tester_go.py", line 58, in json_to_file
    return self._run(arrow_path, json_path, 'JSON_TO_ARROW')
  File "/arrow/dev/archery/archery/integration/tester_go.py", line 52, in _run
    run_cmd(cmd)
  File "/arrow/dev/archery/archery/integration/util.py", line 139, in run_cmd
    raise RuntimeError(sio.getvalue())
RuntimeError: Command failed: ['/opt/go/bin/arrow-json-integration-test', '-arrow', '/tmp/tmpj9b4jgvi/fd6cfe16_generated_decimal.json_as_file', '-json', '/tmp/tmpkz1_ydgp/generated_decimal.json', '-mode', 'JSON_TO_ARROW']
With output:
--------------
arrow-json: could not open JSON file reader from file "/tmp/tmpkz1_ydgp/generated_decimal.json": json: cannot unmarshal number into Go struct field dataType.precision of type string

--------------

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
cc @sbinet

@asfimport
Copy link
Collaborator Author

Micah Kornfield / @emkornfield:
Issue resolved by pull request 10116
#10116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants