Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlightRPC][Java] FlightStream should unwrap ExecutionExceptions #25014

Closed
asfimport opened this issue May 21, 2020 · 1 comment
Closed

[FlightRPC][Java] FlightStream should unwrap ExecutionExceptions #25014

asfimport opened this issue May 21, 2020 · 1 comment

Comments

@asfimport
Copy link

Currently FlightStream bubbles a lot of exceptions as RuntimeException or ExecutionException, or just wraps them with CallStatus.INTERNAL. For RuntimeException, we should always check if it's a gRPC StatusRuntimeException and convert to the equivalent Flight exception; for ExecutionException, we should check if the cause is a gRPC exception and convert.

Example: on master, FlightStream#getDescriptor reports all errors as CallStatus.INTERNAL, but we should inspect ExecutionException#getCause instead.

This is needed so that errors get properly reported, e.g. if a service sends a PERMISSION_DENIED error, the client should get that and not a RuntimeException, ExecutionException, or INTERNAL error.

Reporter: David Li / @lidavidm
Assignee: David Li / @lidavidm

Note: This issue was originally created as ARROW-8879. Please see the migration documentation for further details.

@asfimport
Copy link
Author

David Li / @lidavidm:
This was already fixed in 1.0.0 when FlightStream was refactored for DoExchange.

@asfimport asfimport added this to the 1.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants