Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Add .editorconfig to C# code #25017

Closed
asfimport opened this issue May 21, 2020 · 4 comments
Closed

[C#] Add .editorconfig to C# code #25017

asfimport opened this issue May 21, 2020 · 4 comments
Assignees
Milestone

Comments

@asfimport
Copy link

This allows for a consistent code format throughout the C# code in the repo. That way when a new contributor submits a change, the editors will automatically format the code to be in the same format as the current code base.

Reporter: Eric Erhardt / @eerhardt
Assignee: Eric Erhardt / @eerhardt

PRs and other links:

Note: This issue was originally created as ARROW-8882. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Adam Szmigin / @mr-smidge:
Is there a strong opinion on .editorconfig as opposed to, say, StyleCop Analyzers?

@asfimport
Copy link
Author

Eric Erhardt / @eerhardt:
In general they work together. See https://docs.microsoft.com/en-us/visualstudio/code-quality/analyzers-faq?view=vs-2019. With .edtiorconfig you can specify more settings than just StyleCop.

 

@asfimport
Copy link
Author

Eric Erhardt / @eerhardt:
I also learned through doing this work that if you want to fail the build on violations, you need to use some roslyn analyzer (like StyleCop). I'm not sure failing the build on style violations is a great experience, so I didn't enable it with this work. This issue is just to establish the style used in the project and set the .editorconfig settings.

@asfimport
Copy link
Author

Eric Erhardt / @eerhardt:
Issue resolved by pull request 7246
#7246

@asfimport asfimport added this to the 1.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants