Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add "TypeResolver" class interface to replace current OutputType::Resolver pattern #25052

Open
asfimport opened this issue May 24, 2020 · 0 comments

Comments

@asfimport
Copy link

asfimport commented May 24, 2020

Like the TypeMatcher for extensible input type checking, TypeResolver will allow more flexibility with respect to the output type resolution rule. Currently the resolver function is defined as

using Resolver =
      std::function<Result<ValueDescr>(KernelContext*, const std::vector<ValueDescr>&)>;

By changing to a TypeResolver interface with a virtual Resolve function, we also can provide for better human-readability when printing kernel signatures (by having TypeResolver::ToString) and permitting TypeResolvers to be compared

Reporter: Wes McKinney / @wesm

Related issues:

Note: This issue was originally created as ARROW-8921. Please see the migration documentation for further details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant