Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Gandiva] castDATE_date32() may cause overflow #25054

Closed
asfimport opened this issue May 24, 2020 · 1 comment
Closed

[C++][Gandiva] castDATE_date32() may cause overflow #25054

asfimport opened this issue May 24, 2020 · 1 comment

Comments

@asfimport
Copy link

The following code in cpp/src/gandiva/precompiled/time.cc may cause overflow since int32 * int32 is int32, then it is converted to int64. The result of int32 may loose the part of the result of the multiplication

 

gdv_date64 castDATE_date32(gdv_date32 days) { return days * MILLIS_IN_DAY; } 

Reporter: Kazuaki Ishizaki / @kiszk
Assignee: Kazuaki Ishizaki / @kiszk

PRs and other links:

Note: This issue was originally created as ARROW-8924. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Kouhei Sutou / @kou:
Issue resolved by pull request 7260
#7260

@asfimport asfimport added this to the 1.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants