Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Add a Result<> returning method for for constructing a dictionary #25164

Closed
asfimport opened this issue Jun 5, 2020 · 1 comment
Closed

Comments

@asfimport
Copy link

asfimport commented Jun 5, 2020

Dictionary types require a signed integer index type. Today there is a DCHECK that this is the case in the constructor.

When reading data from an unknown source it is possible due to corruption (or user error) that the dictionary index type is not signed. We should add a method that checks for signedness and use that at all system boundaries to validate input data.

Reporter: Micah Kornfield / @emkornfield
Assignee: Micah Kornfield / @emkornfield

Related issues:

Note: This issue was originally created as ARROW-9049. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
This was done in ARROW-7592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants