Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration] Reconsider generated_large_batch.json #25441

Closed
asfimport opened this issue Jul 7, 2020 · 4 comments
Closed

[Integration] Reconsider generated_large_batch.json #25441

asfimport opened this issue Jul 7, 2020 · 4 comments

Comments

@asfimport
Copy link

The dominant part of the time spent running the integration tests is one test case named "generated_large_batch.json". It is not obvious how useful this test case is. Ideally, integration test cases should be small enough to only take a fraction of a second.

Reporter: Antoine Pitrou / @pitrou
Assignee: David Li / @lidavidm

PRs and other links:

Note: This issue was originally created as ARROW-9358. Please see the migration documentation for further details.

@asfimport
Copy link
Author

David Li / @lidavidm:
It's used to verify that gRPC is configured to allow large message payloads by default in Flight. I think we could reduce the size though (to a few 10s of MBs instead of the very large size it currently is).

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Do we need to use the integration tests for that? It goes through a costly JSON conversion step.

@asfimport
Copy link
Author

David Li / @lidavidm:
That's true. They could be made into in-process tests.

@asfimport
Copy link
Author

Micah Kornfield / @emkornfield:
Issue resolved by pull request 7908
#7908

@asfimport asfimport added this to the 2.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants