Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Reorganize testing headers #25554

Closed
asfimport opened this issue Jul 15, 2020 · 1 comment
Closed

[C++] Reorganize testing headers #25554

asfimport opened this issue Jul 15, 2020 · 1 comment
Assignees
@pitrou
Labels
Component: C++ Type: enhancement
Milestone
7.0.0

Comments

@asfimport
Copy link
Collaborator

Currently, gtest_util.h contains a hodge-podge of different things.
It would be nice if things were separated a bit more, for example a asserts.h file for all home-grown assertion functions and macros.
Also a separate header for ArrayFromVector and friends, to avoid including builder.h everywhere.

Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou / @pitrou

PRs and other links:

Note: This issue was originally created as ARROW-9483. Please see the migration documentation for further details.
@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 12065
#12065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@pitrou @asfimport