Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Flight] IpcWriteOptions do not appear to be propagated in DoGet requests #25664

Closed
asfimport opened this issue Jul 30, 2020 · 6 comments
Closed

Comments

@asfimport
Copy link

I haven't fully investigated this yet, but I have found that while compression (e.g. ZSTD) is respected in DoPut requests on the client side, it does not appear to propagate through DoGet requests. This may be a bug or by design, but I think it should be possible for the client to request that compression be employed when serving a DoGet

Reporter: Wes McKinney / @wesm

Note: This issue was originally created as ARROW-9601. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
cc @lidavidm in case you know off hand before I go down the rabbit hole

@asfimport
Copy link
Author

David Li / @lidavidm:
@wesm the way it was set up, there's no propagation - what the client sets is independent of what the server sets. In this case setting write options for DoGet doesn't make much sense as you're not writing any Arrow data. That is confusing/inconvenient, but building negotiation into Flight is a separate task (did we file a Jira for that/should we just use this one?).

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Right, but I didn't see a way to set the IpcWriteOptions for the server side of handling the RPC, or did I miss it? That seems like a functional gap if so

@asfimport
Copy link
Author

David Li / @lidavidm:
Ah - RecordBatchStream accepts an IpcWriteOptions.

@asfimport
Copy link
Author

David Li / @lidavidm:
Given we've kicked this can down the road a few times: I think we can close it? Compression can be specified server-side, but there's no built-in negotiation (and in ARROW-10351 it's been hard to find a case where compression is beneficial). Or else we can adjust this JIRA to be about implementing negotiation.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
Indeed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant