Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Add integration tests for Decimal type #26627

Closed
Tracked by #19993
asfimport opened this issue Nov 21, 2020 · 2 comments
Closed
Tracked by #19993

[Rust] Add integration tests for Decimal type #26627

asfimport opened this issue Nov 21, 2020 · 2 comments

Comments

@asfimport
Copy link

We have basic decimal support, but we have not yet included decimals in the integration testing.

Reporter: Neville Dipale / @nevi-me
Assignee: Florian Müller / @sweb

PRs and other links:

Note: This issue was originally created as ARROW-10674. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Florian Müller / @sweb:
Hey [~nevi_me],

 

I started to work on the IPC reader for decimal but I ran into an interesting issue, maybe you can help me with this:

As far as I can tell, the values used in arrow/testing/data/arrow-ipc-stream/integration/0.14.1/generated_decimal.arrow_file are encoded as little endian. I was under the impression that big endian is used. This is based on the documentation in the parquet crate. Does the encoding always differ for arrow serialization or am I missing something?

 

In addition, the type is Decimal(3,2), however the values are e.g. -11697. My understanding so far was (again this is probably just true for parquet) that this values does not fit in Decimal(3,2) but if it is actually -116.97 it should be Decimal(5, 2).

 

I am a bit out of my depth here, so if you have some documentation as to when I have to deal with which encoding, that would be very helpful.

@asfimport
Copy link
Author

Jorge Leitão / @jorgecarleitao:
Issue resolved by pull request 8784
#8784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant