Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Gandiva] Fix nested if-else optimisation in gandiva #27482

Closed
asfimport opened this issue Feb 13, 2021 · 1 comment
Closed

[C++][Gandiva] Fix nested if-else optimisation in gandiva #27482

asfimport opened this issue Feb 13, 2021 · 1 comment

Comments

@asfimport
Copy link
Collaborator

In gandiva, when we have nested if-else statements we reuse the local bitmap and treat it is a single logical if - elseif - .. - --else condition. However, when he have say another function between them like
IF
THEN
ELSE
   function(
     IF
     THEN
     ELSE
  )

in such cases also currently we are doing same thing which can lead to incorrect results

Reporter: Projjal Chanda / @projjal
Assignee: Projjal Chanda / @projjal

PRs and other links:

Note: This issue was originally created as ARROW-11617. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Praveen Kumar / @praveenbingo:
Issue resolved by pull request 9486
#9486

@asfimport asfimport added this to the 4.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant