Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Interval is out of spec #27508

Closed
asfimport opened this issue Feb 16, 2021 · 1 comment
Closed

[Rust] Interval is out of spec #27508

asfimport opened this issue Feb 16, 2021 · 1 comment

Comments

@asfimport
Copy link

The DataType interval is currently implemented as a i32 or i64. However, that is incorrect and does not follow the spec.

// DAY_TIME - Indicates the number of elapsed days and milliseconds,
//   stored as 2 contiguous 32-bit integers (8-bytes in total).  Support
//   of this IntervalUnit is not required for full arrow compatibility.

See https://github.com/apache/arrow/blob/master/format/Schema.fbs

E.g. I think that IntervalDayTimeType should be a struct(i32,i32) with a C representation or something, which is how it is defined in the spec.

This would also make it easier to read from and write to, as we do not need to transmute or bitmask the values to get the correct values.

Reporter: Jorge Leitão / @jorgecarleitao

Note: This issue was originally created as ARROW-11645. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Andrew Lamb / @alamb:
Migrated to github: apache/arrow-rs#187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant