Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Refactor collect and compute methods #28089

Closed
asfimport opened this issue Apr 7, 2021 · 1 comment
Closed

[R] Refactor collect and compute methods #28089

asfimport opened this issue Apr 7, 2021 · 1 comment

Comments

@asfimport
Copy link

asfimport commented Apr 7, 2021

ARROW-11754 added a compute() method which calls collect(as_data_frame = FALSE). This was a clean and simple way to add compute(), but it would be more logical if collect() instead called compute(), or if both called an internal function that forced computation of the lazy ops. But this is complicated by the need to call restore_dplyr_features() in both compute() and collect() and muddied by some uncertainty about where exactly ensure_group_vars() and ensure_arrange_vars() should be called. Take a closer look at this later date and consider whether to refactor it.

Reporter: Ian Cook / @ianmcook
Assignee: Neal Richardson / @nealrichardson

Related issues:

Note: This issue was originally created as ARROW-12282. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Neal Richardson / @nealrichardson:
Doing in ARROW-15460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants