Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Use iterators instead of generators in critical code paths #28106

Closed
asfimport opened this issue Apr 8, 2021 · 1 comment
Closed

[JS] Use iterators instead of generators in critical code paths #28106

asfimport opened this issue Apr 8, 2021 · 1 comment

Comments

@asfimport
Copy link

I found that generators are generally slower than iterators in most browsers. See https://observablehq.com/@domoritz/yield-vs-iterator-vs-callback. I attached the results for Chrome. We should consider using iterators instead of generators for iterating over row proxies and vectors. 

Reporter: Dominik Moritz / @domoritz
Assignee: Dominik Moritz / @domoritz

Original Issue Attachments:

PRs and other links:

Note: This issue was originally created as ARROW-12303. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Neal Richardson / @nealrichardson:
Issue resolved by pull request 9962
#9962

@asfimport asfimport added this to the 4.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants