Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] JSON writer does not support time, date or interval types #28119

Closed
asfimport opened this issue Apr 9, 2021 · 1 comment
Closed

[Rust] JSON writer does not support time, date or interval types #28119

asfimport opened this issue Apr 9, 2021 · 1 comment

Comments

@asfimport
Copy link

asfimport commented Apr 9, 2021

While working on #28076 , adding support for writing Timestamp types, I noticed we were also lacking support for other time types. Specifically, if you try to write an array with any of the following types as JSON it will panic:

An example of adding support for timestamps is on #9968

pub type Date32Array = PrimitiveArray<Date32Type>;
pub type Date64Array = PrimitiveArray<Date64Type>;
pub type Time32SecondArray = PrimitiveArray<Time32SecondType>;
pub type Time32MillisecondArray = PrimitiveArray<Time32MillisecondType>;
pub type Time64MicrosecondArray = PrimitiveArray<Time64MicrosecondType>;
pub type Time64NanosecondArray = PrimitiveArray<Time64NanosecondType>;
pub type IntervalYearMonthArray = PrimitiveArray<IntervalYearMonthType>;
pub type IntervalDayTimeArray = PrimitiveArray<IntervalDayTimeType>;
pub type DurationSecondArray = PrimitiveArray<DurationSecondType>;
pub type DurationMillisecondArray = PrimitiveArray<DurationMillisecondType>;
pub type DurationMicrosecondArray = PrimitiveArray<DurationMicrosecondType>;
pub type DurationNanosecondArray = PrimitiveArray<DurationNanosecondType>;

Reporter: Andrew Lamb / @alamb
Assignee: QP Hou / @houqp

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-12317. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Andrew Lamb / @alamb:
Issue resolved by pull request 9993
#9993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants