Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging] Update crossbow to checkout specific git hashes #29077

Closed
asfimport opened this issue Jul 20, 2021 · 3 comments
Closed

[Packaging] Update crossbow to checkout specific git hashes #29077

asfimport opened this issue Jul 20, 2021 · 3 comments

Comments

@asfimport
Copy link

Crossbow was originally designed to checkout a specific hash, but the gandiva-jars required a different checkout approach where arrow-sha is omitted. We need to update the checkout step in the macros.jinja file to use specific commit ids rather than the FETCH_HEAD.

Reporter: Krisztian Szucs / @kszucs
Assignee: Krisztian Szucs / @kszucs

Note: This issue was originally created as ARROW-13408. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Jonathan Keane / @jonkeane:
This is not the exact same, but could be solved at the same time: Should we use -t as the short flag for both arrow-sha and github-token (and also target directory, but I think that's a bit less of a concern and didn't cause the confusion in ARROW-13379)

@click.option('--arrow-sha', '-t', default=None,
              help='Set commit SHA or Tag name explicitly, e.g. f67a515, '
                   'apache-arrow-0.11.1.')

https://github.com/apache/arrow/blob/master/dev/archery/archery/crossbow/cli.py#L96-L98

 
@click.option('--github-token', '-t', default=None,
              envvar="CROSSBOW_GITHUB_TOKEN",
              help='OAuth token for GitHub authentication')

https://github.com/apache/arrow/blob/master/dev/archery/archery/crossbow/cli.py#L33-L35

@asfimport
Copy link
Author

Krisztian Szucs / @kszucs:
We should use different short flags.

BTW If anyone has time the resolution would be to replace the checkout steps in macros.jinja with:

git clone --no-checkout {{ arrow.remote }} arrow
git -C arrow fetch -t {{ arrow.remote }} {{ arrow.branch }}
git -C arrow checkout {{ arrow.head }}
git -C arrow submodule update --init --recursive

@asfimport
Copy link
Author

Krisztian Szucs / @kszucs:
Resolved via #11974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants