Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Use decimal point-aware conversion from fast_float #29188

Closed
asfimport opened this issue Aug 3, 2021 · 2 comments
Closed

[C++] Use decimal point-aware conversion from fast_float #29188

asfimport opened this issue Aug 3, 2021 · 2 comments
Assignees
@pitrou
Labels
Component: C++ Type: task
Milestone
7.0.0

Comments

@asfimport
Copy link
Collaborator

The vendored fast_float library recently added an option to change the decimal point, which we may reuse in the CSV converter instead of translating the input:
fastfloat/fast_float#91

Reporter: Antoine Pitrou / @pitrou
Assignee: Antoine Pitrou / @pitrou

PRs and other links:

Note: This issue was originally created as ARROW-13536. Please see the migration documentation for further details.
@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
cc @bkietz

@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 11817
#11817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Type: task
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@pitrou @asfimport